[Mellanox] Update the test_check_sfp_eeprom due to design change#22561
Open
JibinBao wants to merge 1 commit intosonic-net:masterfrom
Open
[Mellanox] Update the test_check_sfp_eeprom due to design change#22561JibinBao wants to merge 1 commit intosonic-net:masterfrom
JibinBao wants to merge 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
github-actions
bot
requested review from
Junchao-Mellanox,
vaibhavhd and
xwjiang-ms
|
Azure Pipelines successfully started running 1 pipeline(s). |
1. Update the function to get the port with flat memory, because the PR sonic-net/sonic-utilities#3950 removed the string of 'DOM values not supported for flat memory module' from the output of "sudo sfputil show eeprom -d" 2. To avoid a circular import, move get_ports_with_flat_memory from platform/transceiver_utils.py to platform/interface_utils.py. 3. Update test_check_sfp_eeprom_with_option_dom: For ports that do not have flat memory, it implies DOM support. Remove the old code for checking DOM support, as the previous method is no longer applicable. Signed-off-by: jbao <jbao@nvidia.com>
JibinBao
force-pushed
the
fix_sfp_eeprom_issue
branch
from
753b8fe to
8151da4
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-mgmt |
Collaborator
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines failed to run 1 pipeline(s). |
nhe-NV
added
the
Request for 202511 branch
nhe-NV
approved these changes
Mar 1, 2026
Contributor
Author
|
/azpw run Azure.sonic-mgmt |
Collaborator
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@JibinBao Will this PR address this issue? |
Contributor
Author
|
/azpw run Azure.sonic-mgmt |
Collaborator
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
@bingwang-ms yes |
Contributor
Author
|
/azpw run Azure.sonic-mgmt |
Collaborator
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@prgeor Can you help review? |
Contributor
Author
|
/azpw run Azure.sonic-mgmt |
Collaborator
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-mgmt |
Collaborator
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-mgmt |
Collaborator
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Update tests/platform_tests/mellanox/test_check_sfp_eeprom.py due to design change
How did you do it?
Update the function to get the port with flat memory
How did you verify/test it?
Run the test on mellanox device
Any platform specific information?
Any
Supported testbed topology if it's a new test case?
Documentation